[Octave-bug-tracker] [bug #65037] constructor argument getting lost

[Markus Mützel]

Update of bug#65037 (group octave):

                  Status:               Confirmed => Patch Reviewed         
         Planned Release:                    None => 9.1.0 (current stable) 

    _______________________________________________________

Follow-up Comment #4:

I also find that part of the code pretty confusing.

If I understand your changes correctly, it let's the fcn_info class know that
superclass names aren't actually "proper" method names of a classdef subclass.
I.e., the test code from comment #0 didn't actually mean to call `b3 =
s.mybaseclass();`.

I'm struggling to understand the `else`-part (search parent classes). Is
`name` the name of the class of `s` in that example?

I agree that a method that would do what you describe in the FIXME note would
make that a lot easier to understand. But that can also happen later.

As far as I understand them, the changes look good to me. I think it is ok to
fix this on stable.
However, the code didn't link with enabled visibility attributes on Windows
unless I added an API flag to the declaration of the new function that is
defined outside the header. See the attached updated patch.

A BIST for this would be nice. 👍


(file #55617)

    _______________________________________________________

Additional Item Attachment:

File name: bug-65037-v2.patch             Size:4 KB
    <https://file.savannah.gnu.org/file/bug-65037-v2.patch?file_id=55617>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-bd5dc6a791eeb858c14bff2c54b74c7dcaee57e4.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65037>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/