[Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes

[Markus Mützel]

Follow-up Comment #34, bug #46451 (project octave):

I'm seeing the following warning during compilation (that I forgot to mention
before):

  CXX      libinterp/octave-value/liboctave_value_la-cdef-class.lo
../libinterp/octave-value/cdef-class.cc: In member function 'octave_value
octave::cdef_class::cdef_class_rep::get_method(size_t) const':
../libinterp/octave-value/cdef-class.cc:734:16: warning: comparison of integer
expressions of different signedness: 'size_t' {aka 'long long unsigned int'}
and 'const int' [-Wsign-compare]
  734 |       if (line <= e && e <= closest_match_end_line && pfcn->is_defined
()
      |           ~~~~~^~~~


Many functions that are added by this patch seem to be using `int` as the type
for line numbers. But `cdef_class::cdef_class_rep::get_method` uses `size_t`.
Would it make sense to use the same type for all these functions?



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?46451>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/