[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!t
From: |
John W. Eaton |
Subject: |
[Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files |
Date: |
Thu, 5 Nov 2020 10:09:49 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 |
Follow-up Comment #42, bug #41298 (project octave):
If it works for you, then it's fine with me to apply this change to stable.
Could you fix this line
tst_code = [sprintf("## DO NOT EDIT! \
Generated automatically from %s by %s during package installation.\n",
tst_file_src{1}, "configure_make.m"), tst_code];
to not mix sprintf and [] for concatenation? Also, it seems strange to me to
use a %s format specifier to substitute the "configure_make.m" string literal.
Perhaps change that to
tst_code = ["## DO NOT EDIT!\n" ...
"## Generated automatically from ", tst_file_src{1}, "\n" ...
"## by configure_make.m during package installation.\n" ...
tst_code];
?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?41298>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2020/11/01
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Markus Mützel, 2020/11/03
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2020/11/03
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Markus Mützel, 2020/11/03
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files,
John W. Eaton <=
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2020/11/05
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Markus Mützel, 2020/11/05
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2020/11/05
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2020/11/05
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Markus Mützel, 2020/11/06
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2020/11/06
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Markus Mützel, 2020/11/06
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Markus Mützel, 2020/11/23