[Octave-bug-tracker] [bug #55741] build with '-Woverloaded-virtual' emits many warnings indicating problems

[Mike Miller]

URL:
  <https://savannah.gnu.org/bugs/?55741>

                 Summary: build with '-Woverloaded-virtual' emits many
warnings indicating problems
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Tue 19 Feb 2019 07:10:22 PM PST
                Category: Configuration and Build System
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Other
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

Building the default branch with the warning option '-Woverloaded-virtual'
emits many warnings, see attached log file produced by GCC 8.

These should be fixed, because the warning indicates that a non-virtual
function in a derived class may be accidentally shadowing a virtual function
with the same name, breaking the intended virtual function dispatching.

Should we also add '-Woverloaded-virtual' to the standard set of warnings to
make sure these are fixed and don't crop up again?

I will try to find some time to go through the raw log and list the specific
class member functions that are problems, many of the warnings are duplicated
each time a header file is included.

@cdf - feel free to attach any additional warnings you saw with Clang if they
aren't covered by the GCC warnings in my log file.

Inspired by
https://lists.gnu.org/archive/html/octave-maintainers/2019-02/msg00120.html.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 19 Feb 2019 07:10:22 PM PST  Name: Woverloaded-virtual.log.gz  Size:
87KiB   By: mtmiller

<http://savannah.gnu.org/bugs/download.php?file_id=46308>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55741>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/