[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nmh-workers] Updates to nmh
From: |
Doug Porter |
Subject: |
Re: [Nmh-workers] Updates to nmh |
Date: |
Fri, 16 Jan 2009 15:14:30 +0000 |
Ken Hornstein <address@hidden> writes:
>
> - All networking calls now converted to new APIs
> (getaddrinfo(), sockaddr_storage, and the like).
I only took a quick glance, but I think there may be some issues
with freeaddrinfo() use. For example, in sbr/client.c client() a
NULL pointer can be passed to freeaddrinfo(). That doesn't work
on a lot of platforms. Second, it seems memory is being leaked
in that function if you get a result set from getaddrinfo(), but
fail to connect and then call getaddrinfo() again with a
different host.
Additionally, I don't know if you can assume that res will be set
to NULL if getaddrinfo() fails. Since the spec doesn't specify,
I figure it could be in any state on error: NULL, never changed,
or pointing at a result set.
--
dsp
- [Nmh-workers] Updates to nmh, Ken Hornstein, 2009/01/15
- Re: [Nmh-workers] Updates to nmh, Joel Uckelman, 2009/01/16
- Re: [Nmh-workers] Updates to nmh,
Doug Porter <=
- Re: [Nmh-workers] Updates to nmh, Peter Maydell, 2009/01/16
- Re: [Nmh-workers] Updates to nmh, Ken Hornstein, 2009/01/16
- Re: [Nmh-workers] Updates to nmh, Peter Maydell, 2009/01/16
- Re: [Nmh-workers] Updates to nmh, Ken Hornstein, 2009/01/21
- Re: [Nmh-workers] Updates to nmh, Peter Maydell, 2009/01/25
- Re: [Nmh-workers] Updates to nmh, Ken Hornstein, 2009/01/26
- Re: [Nmh-workers] Updates to nmh, Robert Elz, 2009/01/26
- Re: [Nmh-workers] Updates to nmh, Anders Eriksson, 2009/01/27
- Re: [Nmh-workers] Updates to nmh, Ken Hornstein, 2009/01/27