[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nmh-workers] Changing the return type of done()
From: |
Peter Maydell |
Subject: |
Re: [Nmh-workers] Changing the return type of done() |
Date: |
Wed, 18 Apr 2007 09:42:39 +0100 |
Joel Reicher wrote:
>I've thought a bit more about this, and am now thinking of changing
>
>return done(status);
>
>to
>
>done(status);
>assert(0); /* done() shouldn't have returned */
>return 1;
>
>to emphasise that the return should not be reached. What do you think?
>Is this overkill?
I'd tend to prefer something like:
done(status);
/* NOTREACHED */
(traditionally a comment for lint, but I use it as a note to the reader.)
That tells the reader that done() never returns, and doesn't put in
extra random junk. Placation of the compiler's warnings should be done
with a function attribute.
-- PMM
- [Nmh-workers] Changing the return type of done(), Joel Reicher, 2007/04/17
- Re: [Nmh-workers] Changing the return type of done(), Peter Maydell, 2007/04/17
- Re: [Nmh-workers] Changing the return type of done(), Joel Reicher, 2007/04/17
- Re: [Nmh-workers] Changing the return type of done(), Peter Maydell, 2007/04/17
- Re: [Nmh-workers] Changing the return type of done(), Joel Reicher, 2007/04/18
- Re: [Nmh-workers] Changing the return type of done(),
Peter Maydell <=
- Re: [Nmh-workers] Changing the return type of done(), Josh Bressers, 2007/04/18
- Re: [Nmh-workers] Changing the return type of done(), Joel Reicher, 2007/04/18
- Re: [Nmh-workers] Changing the return type of done(), Peter Maydell, 2007/04/19
- Re: [Nmh-workers] Changing the return type of done(), Joel Reicher, 2007/04/19
- Re: [Nmh-workers] Changing the return type of done(), Lyndon Nerenberg, 2007/04/19
- Re: [Nmh-workers] Changing the return type of done(), Joel Reicher, 2007/04/19
- Re: [Nmh-workers] Changing the return type of done(), Valdis . Kletnieks, 2007/04/19
- Re: [Nmh-workers] Changing the return type of done(), Josh Bressers, 2007/04/19
Re: [Nmh-workers] Changing the return type of done(), Josh Bressers, 2007/04/17