monotone-commits-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-commits-diffs] net.venge.monotone.issue-120: 1ce52abe1d12b891


From: code
Subject: [Monotone-commits-diffs] net.venge.monotone.issue-120: 1ce52abe1d12b891c5c5783921287f41b5915b30
Date: Thu, 24 Feb 2011 18:19:08 +0100 (CET)

revision:            1ce52abe1d12b891c5c5783921287f41b5915b30
date:                2011-02-24T17:18:15
author:              Richard Hopkins <address@hidden>
branch:              net.venge.monotone.issue-120
changelog:
changed_nodes_summary now uses switch instead of if/else and added
invariant

Just to clarify which statuses are expected and can be handled.

manifest:
format_version "1"

new_manifest [bf23b8809c8300e6118ede2cc8edf1d5a401673c]

old_revision [d64b5a55c55430187f13db7f5e7f4fc4dfd0649d]

patch "src/cmd_list.cc"
 from [b51a543bb760d2fb37eda377a229ee56f9c24c60]
   to [1cc5fa3d3b5864d6f7f348889f6b91823c2307c2]
============================================================
--- src/cmd_list.cc	b51a543bb760d2fb37eda377a229ee56f9c24c60
+++ src/cmd_list.cc	1cc5fa3d3b5864d6f7f348889f6b91823c2307c2
@@ -874,11 +874,25 @@ namespace
       // we output the new filename (fp_second) for renames,
       // and the original (fp_first) for the others as they don't have a
       // new filename
-      if (status == renamed)
-        output_files.insert(fp_second);
-      else
-        output_files.insert(fp_first);
+      switch (status)
+        {
+          case added:
+          case attr_set:
+          case attr_unset:
+          case dropped:
+          case patched:
+            output_files.insert(fp_first);
+            break;
 
+          case renamed:
+            output_files.insert(fp_second);
+            break;
+
+          default:
+            I(false); // should never get here
+            break;
+        }
+
       return "";
     }
   }

reply via email to

[Prev in Thread] Current Thread [Next in Thread]