[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Monotone-commits-diffs] Revision 61a83351e0e24a39e2c413104b8a933c5768bd
From: |
monotone |
Subject: |
[Monotone-commits-diffs] Revision 61a83351e0e24a39e2c413104b8a933c5768bd42 |
Date: |
Fri, 1 Feb 2008 19:05:32 +0100 |
-----------------------------------------------------------------
Revision: 61a83351e0e24a39e2c413104b8a933c5768bd42
Ancestor: c246ea7ffce7984e4a8101e0714e68f29e399834
Author: address@hidden
Date: 2008-01-30T19:13:26
Branch: net.venge.monotone.experiment.encapsulation
Modified files:
cmd_key_cert.cc platform.hh ssh_agent.cc ssh_agent.hh
unix/ssh_agent_platform.cc unix/ssh_agent_platform.hh
win32/ssh_agent_platform.cc win32/ssh_agent_platform.hh
ChangeLog:
Clean up the ssh-agent support and hide its implementation from the interface
headers.
* platform.hh: Don't include either variant of ssh_agent_platform.hh.
* ssh_agent.hh: Prune most headers. Forward-declare Botan::RSA_PublicKey and
Botan::RSA_PrivateKey. Add pointer to implementation, remove all private
methods and data members.
* ssh_agent.cc: Most of ssh_agent_hh's former includes moved here. Include
the appropriate variant of ssh_agent_platform.hh. Define struct
ssh_agent_state. Make get_long, get_long_from_buf, get_string_from_buf,
put_long, put_long_into_buf, put_string_into_buf, put_bigint_into_buf,
put_public_key_into_buf, and put_private_key_into_buf into static
non-method functions. Rename fetch_packet to read_packet, add
write_packet, and make them both ssh_agent_state methods. Define
nontrivial constructor and destructor for ssh_agent object, replacing
connect() and disconnect() methods. Tidy up the actual ssh_agent methods,
removing commented-out junk code and unnecessary string bashing.
* unix/ssh_agent_platform.cc, unix/ssh_agent_platform.hh: Initialize the
connection in the ssh_agent_platform constructor (with a helper method) and
avoid the use of boost::shared_ptr. Rely on the Netxx::Stream destructor
to tear down the connection. Usage of read_data() or write_data() if not
connected() is an invariant failure.
* win32/ssh_agent_platform.cc, win32/ssh_agent_platform.hh: Initialize the
connection in the constructor and tear it down in the destructor. Usage of
read_data() or write_data() if not connected() is an invariant failure.
* cmd_key_cert.cc: Include botan/rsa.h.
txtPMTKOflhAi.txt
Description: Diff [c246ea7ffce7984e4a8101e0714e68f29e399834] -> [61a83351e0e24a39e2c413104b8a933c5768bd42]
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Monotone-commits-diffs] Revision 61a83351e0e24a39e2c413104b8a933c5768bd42,
monotone <=