[Mldonkey-bugs] [bug #19818] Share priorities do not work on MinGW

[spiralvoice]

Update of bug #19818 (project mldonkey):

                  Status:                    None => Ready For Test         
                 Release:                   2.8.5 => 2.9.2                  

    _______________________________________________________

Follow-up Comment #2:

First of all, this is really a bug, code was introduced to commonShared.ml in
September 2002...

Your fix is correct, but it solves only the symptom, not the reason for this
bug.

impl.impl_shared_codedname is filled in function commonShared.new_shared

  let codedname = Filename.concat dirname filename in

Example: dirname = "shared2", filename "some_file.txt"
Result: on Unix: "shared2/some_file.txt", on MinGW: "shared2\some_file.txt"

Its a bad idea to use hard-coded seperators, like

String.index codedname '/'

in commonShared.ml anyway, but as it dates back to a time
where MinGW support was not present (it was started in Dec 2002)
I guess no one thought about it. It assumed "/" as seperator,
but this code fails on MinGW due to usage of "\" as seperator
in Ocaml´s Filename.concat function.

Ocaml has a special function to seperate Filename.concat strings
using Filename.dirname while taking care of the correct seperator.

Please try the attached patch. It works for me.
In HTML, upstats you can see the patch working when you look
at the slot column.

(file #14758)
    _______________________________________________________

Additional Item Attachment:

File name: share_prio_mingw.patch         Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19818>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/