[Mldonkey-bugs] [bug #9391] Files copied to incoming dir for sharing do not appear in upstats after hashing

[spiralvoice]

Follow-up Comment #3, bug #9391 (project mldonkey):

I attached a patch for testing.

It removes a line in donkeyShare where a shared file is removed from
the list maintained by commonUploads after a new file has been hashed.

This is not necessary because one line above donkeyShare.new_file_to_share
is called which itself calls donkeyShare.must_share_file with the
old (old_impl) and the new file-data.

donkeyShare.must_share_file takes care of updating the list of shared
files
      match has_old_impl with
        None -> update_shared_num impl
      | Some old_impl -> replace_shared old_impl impl

Here it replaces the line in upstats with the zeroed MD4 with the
new hashed data (replace_shared old_impl impl) provided by
new_file_to_share called by check_shared_files.

So why call shared_remove there when new_file_to_share already
took care of updating the list and replacing the old with the
new entry?

Some testing here showed good results, copying new files into the
share and downloading files worked. Also the double lines for
finished downloads went away one the first look.

Please report how this patch works for you.
    _______________________________________________________

Additional Item Attachment:

File name: upstats.patch                  Size:1 KB

<http://savannah.nongnu.org/bugs/download.php?item_id=9391&item_file_id=2593>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9391>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/