[Mldonkey-bugs] [bugs #10861] lots of ip's with an ending .0 in file_sources.ini like 20%

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #10861] Latest Modifications:

Changes by: 
                spiralvoice <address@hidden>
'Date: 
                Mit 03.11.2004 at 00:01 (Europe/Berlin)

------------------ Additional Follow-up Comments ----------------------------
Before changing this again we should think again. Ips like xxx.xxx.xxx.0 are 
valid ones AFAIK.
They are LowID on EDK network because of design flaws on the part of 
Metamachine,
see the Wiki page about Donkey network, I posted some limitations there.






/**************************************************************************/
[bugs #10861] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=10861>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: 0
On: Mon 01.11.2004 at 17:13

Category:  Core
Severity:  5 - Average
Item Group:  Program malfunction
Resolution:  None
Privacy:  Public
Assigned to:  None
Status:  Open
Release:  2-5-28
Release:  2-5-28h
Platform Version:  Linux
Binaries Origin:  CVS / Self compiled
CPU type:  Intel x86


Summary:  lots of ip's with an ending .0 in file_sources.ini like 20%

Original Submission:  I wonder why mldonkey is keeping sources with ips like 
x.x.x.0, it marks them as blacklisted but it keeps them in file_sources.ini 
pango said negative caching ? to avoid finding them again ? That said, if the 
only reason for blacklisting them is that they end in .0, they could have been 
discarded from the beginning...
But for me it looks like some errorneus implementation in the ip decoding, 
because they make about 20% of my file_sources.ini Just discarding the sources 
and not storing them at any point would be more efficient.


Follow-up Comments
------------------


-------------------------------------------------------
Date: Mit 03.11.2004 at 00:01       By: spiralvoice <spiralvoice>
Before changing this again we should think again. Ips like xxx.xxx.xxx.0 are 
valid ones AFAIK.
They are LowID on EDK network because of design flaws on the part of 
Metamachine,
see the Wiki page about Donkey network, I posted some limitations there.

-------------------------------------------------------
Date: Die 02.11.2004 at 12:14       By: 0 <None>
like noud said on irc these may be valid ip's (even if they most of the time 
aren't) so please:
if you fix the valid donkey-ip thingie make a comment about that
or better make the block-list thingie able to handle them (i don't know if it 
is able to handle regex or something like it) so one can just add them to a 
blocklist

-Amorphous

-------------------------------------------------------
Date: Die 02.11.2004 at 01:15       By: Valentin Batz <senneth>
The problem may be caused by the 2.5.28h patch by spiralvoice which includes a 
patch to src/net/ip.ml, it changes the 'valid' function so it treats x.x.x.0 
ips as valid.













For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=10861>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/