[Mldonkey-bugs] [bugs #9996] Missing Date Header in Emails

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #9996] Latest Modifications:

Changes by: 
                spiralvoice <address@hidden>
'Date: 
                Sat 08/14/2004 at 18:35 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Patched patch is on Savannah:
http://savannah.nongnu.org/patch/index.php?func=detailitem&item_id=3291
Thanks for the help!






/**************************************************************************/
[bugs #9996] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9996>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: 0
On: Thu 08/12/2004 at 22:21

Category:  Core
Severity:  5 - Average
Item Group:  Compilation problem
Resolution:  Fixed
Assigned to:  None
Status:  Closed
Release:  2-5-27
Release:  
Platform Version:  Linux
Binaries Origin:  Debian package
CPU type:  Intel x86


Summary:  Missing Date Header in Emails

Original Submission:  mldonkey does not include a Date: header in the emails it 
generates when a download is complete.
This leads to some confusion for users with MUAs that sort the mail folders by 
date (i.e. those mails appear as last and are not noticed)
P.S. I am using exim 4.34 as MTA.

Follow-up Comments
------------------


-------------------------------------------------------
Date: Sat 08/14/2004 at 18:35       By: spiralvoice
Patched patch is on Savannah:
http://savannah.nongnu.org/patch/index.php?func=detailitem&item_id=3291
Thanks for the help!

-------------------------------------------------------
Date: Fri 08/13/2004 at 18:48       By: None
the following "patch" for the patch fixes the problem:

address@hidden:~$ diff -c mail_bug9996.patch mail_bug9996_v2.patch
*** mail_bug9996.patch  2004-08-13 15:06:42.000000000 +0000
--- mail_bug9996_v2.patch       2004-08-13 18:41:09.000000000 +0000
***************
*** 98,105 ****
  +     mail.mail_from
  +     mail.mail_to
  +     mail.mail_subject
- +     mail.mail_body
  +     mail_date
       else
  -  Printf.sprintf
  -     "From: mldonkey %srnTo: %srnSubject: %srnMIME-Version: 
1.0rnContent-Type: text/plainrnrn%s"
--- 98,105 ----
  +     mail.mail_from
  +     mail.mail_to
  +     mail.mail_subject
  +     mail_date
+ +     mail.mail_body
       else
  -  Printf.sprintf
  -     "From: mldonkey %srnTo: %srnSubject: %srnMIME-Version: 
1.0rnContent-Type: text/plainrnrn%s"
***************
*** 112,119 ****
  +     mail.mail_from
  +     mail.mail_to
  +     mail.mail_subject
- +     mail.mail_body
  +     mail_date

   let canon_addr s =
     let len = String.length s in
--- 112,119 ----
  +     mail.mail_from
  +     mail.mail_to
  +     mail.mail_subject
  +     mail_date
+ +     mail.mail_body

   let canon_addr s =
     let len = String.length s in


-------------------------------------------------------
Date: Fri 08/13/2004 at 18:29       By: None
thanks for your quick response, but the patch seems mess up with the lines.
see the following tcpdump of the smtp conversion:

220 deprecated.cologne.reucon.net ESMTP Exim 4.34 Fri, 13 Aug 2004 18:25:14 
+0000^M
HELO endorsed.cologne.reucon.net^M
250 deprecated.cologne.reucon.net Hello mldonkey at endorsed.cologne.reucon.net 
[10.13.0.55]^M
MAIL FROM:<address@hidden>^M
250 OK^M
RCPT TO:<address@hidden>^M
250 Accepted^M
DATA^M
354 Enter message, ending with "." on a line by itself^M
From: mldonkey <address@hidden>^M
To: address@hidden
Subject: [mldonkey] file received - Readme.txt^M
MIME-Version: 1.0^M
Content-Type: text/plain^M
Date: mldonkey has completed the download of:^M
^M
File: Readme.txt^M
Size: 3081 bytes^M
^M
Fri, 13 Aug 2004 18:15:53^M
.^M
250 OK id=1Bvgjr-0004ks-5G^M
QUIT^M
221 deprecated.cologne.reucon.net closing connection^M


-------------------------------------------------------
Date: Fri 08/13/2004 at 15:09       By: spiralvoice
Please test this patch:
http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&t=2834












For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9996>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/