[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Mldonkey-bugs] [bugs #7741] No donkey servers can ever become `masters'
From: |
spiralvoice |
Subject: |
[Mldonkey-bugs] [bugs #7741] No donkey servers can ever become `masters' |
Date: |
Tue, 10 Aug 2004 23:39:59 -0400 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.7) Gecko/20040616 |
This mail is an automated notification from the bugs tracker
of the project: mldonkey, a multi-networks file-sharing client.
/**************************************************************************/
[bugs #7741] Latest Modifications:
Changes by:
spiralvoice <address@hidden>
'Date:
Tue 08/10/2004 at 18:43 (Europe/Berlin)
What | Removed | Added
---------------------------------------------------------------------------
Severity | 5 - Average | 1 - None
------------------ Additional Follow-up Comments ----------------------------
Changing severity to 1 because this bug might be solved in current CVS release.
/**************************************************************************/
[bugs #7741] Full Item Snapshot:
URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7741>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: 0
On: Mon 02/16/2004 at 08:12
Category: eDonkey-plugin
Severity: 1 - None
Item Group: Program malfunction
Resolution: None
Assigned to: None
Status: Open
Release: 2-5-10
Release: 2.5-10
Platform Version: Linux
Binaries Origin: CVS / Self compiled
CPU type: None
Summary: No donkey servers can ever become `masters'
Original Submission: A requirement for donkey servers to become `masters' is
that the candidate must have been connected for at least two minutes; however,
this time is reset every time a response to any query is received, perhaps due
to the slightly misleading name of the call used to set this: connection_ok.
Queries are sent at least once every minute and no workaround seems possible
because file_queries_initial_delay is current ineffectual. (i.e. MLDonkey
kills the network - again.)
No other networks seem to have such mistakes, although it is worth checking.
Follow-up Comments
------------------
-------------------------------------------------------
Date: Tue 08/10/2004 at 18:43 By: spiralvoice
Changing severity to 1 because this bug might be solved in current CVS release.
-------------------------------------------------------
Date: Mon 08/09/2004 at 18:30 By: spiralvoice
Please test CVS 2-5-25 and report if the bugs is still present.
-------------------------------------------------------
Date: Sun 07/25/2004 at 21:50 By: spiralvoice
How can I see that a server became master server?
-------------------------------------------------------
Date: Wed 03/31/2004 at 22:48 By: None
I'm pretty sure that I understand the cause, and I'm absolutely sure that it's
currently broken.
For added confusion, there are two definitions of update_master_servers in the
one file. (src/networks/donkey/donkeyServers.ml)
Removing the sole occurrence of connection_ok s.server_connection_control from
donkeyClient.ml fixed this for me.
-------------------------------------------------------
Date: Fri 03/12/2004 at 15:09 By: HighTime
Are you sure ?
This seems correct to me :
if not s.server_master && s.server_cid <> None then
if !nmasters < max_allowed_connected_servers () &&
s.server_nusers >= !!master_server_min_users
then begin
do_if_connected s.server_sock (fun sock ->
s.server_master <- true;
incr nmasters;
direct_server_send_share s.server_has_zlib sock
(DonkeyShare.all_shared ())
)
end else
if connection_last_conn s.server_connection_control
Did you noticed the "else" before "if connection last..."?
File Attachments
-------------------
-------------------------------------------------------
Date: Fri 07/23/2004 at 00:39 Name: donkey_server_master.patch Size: 533B
By: spiralvoice
please try this patch - not tested
http://savannah.nongnu.org/bugs/download.php?item_id=7741&item_file_id=1514
For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7741>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/