[Mldonkey-bugs] [bugs #9929] Replace donkeyOvernet.private_address with ip..reachable

[mldonkey admin]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #9929] Latest Modifications:

Changes by: 
                mldonkey admin <address@hidden>
'Date: 
                Mon 08/09/2004 at 18:06 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
            Severity | 3 - Ordinary              | 1 - None


------------------ Additional Follow-up Comments ----------------------------
fixed in 2.5.25






/**************************************************************************/
[bugs #9929] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9929>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: spiralvoice
On: Sun 08/08/2004 at 21:37

Category:  Overnet-Plugin
Severity:  1 - None
Item Group:  None
Resolution:  None
Assigned to:  None
Status:  Open
Release:  2-5-24
Release:  
Platform Version:  None
Binaries Origin:  CVS / Self compiled
CPU type:  None


Summary:  Replace donkeyOvernet.private_address with ip..reachable

Original Submission:  From donkeyOvernet.ml
let private_address ip =
  Ip.matches ip [(Ip.of_string "0.0.0.0"); (Ip.of_string "127.0.0.255"); 
                 (Ip.of_string "10.255.255.255"); (Ip.of_string 
"192.168.255.255") ] 

>From ip.ml

let reachable ip = 
  !allow_local_network ||
  match ip with
    192, 168,_,_ -> false
  | 10, _, _, _ | 127, _,_,_ -> false
  | 172, v, _, _ when v > 15 && v < 32 -> false
  | _ -> true

The second function is more complete, it recognizes !allow_local_network
and the 172.16.0.0-172.31.255.255 which is also private according to RFC 1918:
http://www.faqs.org/rfcs/rfc1918.html

Please also have a look at bug 7520:
http://savannah.nongnu.org/bugs/index.php?func=detailitem&item_id=7520

Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 08/09/2004 at 18:06       By: mldonkey
fixed in 2.5.25












For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9929>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/