[Mldonkey-bugs] [bugs #8705] Missing port value in HTTP Host header

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #8705] Latest Modifications:

Changes by: 
                spiralvoice <address@hidden>
'Date: 
                Fri 07/23/04 at 01:41 (Europe/Berlin)

------------------ Additional Follow-up Comments ----------------------------
This patch does not compile with CVS 2-5-16 and Ocaml-3.08.0:
File "src/utils/net/http_client.ml", line 93, characters 86-89:
This expression is not a function, it cannot be applied

Line 93 is this one:
  Printf.bprintf res " HTTP/1.0rnHost: %s%srn" url.server (if url.port != 80 
then ":" url.port else "");







/**************************************************************************/
[bugs #8705] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=8705>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: 0
On: Mon 04/26/04 at 22:51

Category:  HTTP interface
Severity:  5 - Average
Item Group:  Program malfunction
Resolution:  None
Assigned to:  None
Status:  Open
Release:  2-5-16
Release:  
Platform Version:  None
Binaries Origin:  CVS / Self compiled
CPU type:  None


Summary:  Missing port value in HTTP Host header

Original Submission:  When MLDK connects a Gnutella Web Cache the hostname in 
the Host header is not followed port value even if the server isn't on TCP port 
80. For example, if the server is on port 8080, the header should look like 
this:

Host: gwc.example.com:8080

MLDK however sends this:

Host: gwc.example.com

Which implies port 80. Most HTTP servers probably ignore this, but I wouldn't 
rely on it. I assume this a generic problem of the HTTP interface and not only 
in the Gnutella plug-in.

christianbiere at gmx de

Follow-up Comments
------------------


-------------------------------------------------------
Date: Fri 07/23/04 at 01:41         By: spiralvoice
This patch does not compile with CVS 2-5-16 and Ocaml-3.08.0:
File "src/utils/net/http_client.ml", line 93, characters 86-89:
This expression is not a function, it cannot be applied

Line 93 is this one:
  Printf.bprintf res " HTTP/1.0rnHost: %s%srn" url.server (if url.port != 80 
then ":" url.port else "");


-------------------------------------------------------
Date: Tue 05/11/04 at 03:02         By: None
I think the problem is in src/utils/net/http_client.ml (see attachment). I 
don't know whether the syntax in my patch is correct but you should get the 
idea. The patch corrects also the HTTP User-Agent header. The product version 
should be separated by a '/' not a whitespace (see RFC 2616 section 3.8). It's 
a pitty that this header isn't set in *one* place but all over the place and 
the caps weren't consistent either.






File Attachments
-------------------

-------------------------------------------------------
Date: Tue 05/11/04 at 03:02  Name: mldonkey.udif  Size: 5.66KB   By: None
Fixes User-Agent and missing port in Host (against mldonkey-2.5.21)
http://savannah.nongnu.org/bugs/download.php?item_id=8705&amp;item_file_id=1289






For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=8705>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/