[Mldonkey-bugs] [bugs #7965] telnet command "cs" shows stats twice - and wrong

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #7965] Latest Modifications:

Changes by: 
                spiralvoice <address@hidden>
'Date: 
                Sun 05/02/04 at 21:07 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Solved with patch 3002






/**************************************************************************/
[bugs #7965] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7965>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: Mark-Oliver Wolter
On: Mon 03/01/04 at 20:29

Category:  Telnet interface
Severity:  3 - Ordinary
Item Group:  Program malfunction
Resolution:  Fixed
Assigned to:  None
Status:  Closed
Release:  2.5.12
Release:  2-5-12
Platform Version:  Linux
Binaries Origin:  CVS / Self compiled
CPU type:  None


Summary:  telnet command "cs" shows stats twice - and wrong

Original Submission:  Moin,

in 2-5-12 (downloaded tarball) the "cs" output is strange:
Session Uptime: 28808 seconds (0 days 8 hours 0 minutes)
Client Brand|    seen    |     Downloads     |      Uploads      |   Banned   | 
 Requests
------------+------------+-------------------+-------------------+------------+------------
eDonkey     |    740   5%|    47.7   1.7  38%|    13.9   0.5   7%|      0   0%| 
   322   2%
Overnet     |   3778  26%|    15.0   0.5  12%|     1.7   0.1   1%|      0   0%| 
  3787  26%
eMule       |   8986  62%|    63.4   2.3  50%|   163.6   5.8  86%|      0   0%| 
  7893  55%
trusted mld |    166   1%|     0.0   0.0   0%|     0.0   0.0   0%|      1  25%| 
  1695  12%
xMule       |     34   0%|     0.0   0.0   0%|     0.0   0.0   0%|      0   0%| 
    35   0%
shareaza    |    632   4%|     0.0   0.0   0%|     4.8   0.2   3%|      3  75%| 
   626   4%
aMule       |     36   0%|     0.0   0.0   0%|     6.6   0.2   3%|      0   0%| 
    36   0%
------------+------------+-------------------+-------------------+------------+------------
Total       |  14417     |   126.1   4.5     |   190.5   6.8     |      4     | 
 14394

Total Uptime: 28809 seconds (0 days 8 hours 0 minutes)
Client Brand|    seen    |     Downloads     |      Uploads      |   Banned   | 
 Requests
------------+------------+-------------------+-------------------+------------+------------
eDonkey     |    740   5%|    47.7   1.7  38%|    13.9   0.5   7%|      0   0%| 
   322   2%
Overnet     |   3778  26%|    15.0   0.5  12%|     1.7   0.1   1%|      0   0%| 
  3787  26%
eMule       |   8986  63%|    63.4   2.3  50%|   163.6   5.8  86%|      0   0%| 
  7893  55%
trusted mld |    166   1%|     0.0   0.0   0%|     0.0   0.0   0%|      1  25%| 
  1695  12%
xMule       |     34   0%|     0.0   0.0   0%|     0.0   0.0   0%|      0   0%| 
    35   0%
shareaza    |    632   4%|     0.0   0.0   0%|     4.8   0.2   3%|      3  75%| 
   626   4%
aMule       |     36   0%|     0.0   0.0   0%|     6.6   0.2   3%|      0   0%| 
    36   0%
------------+------------+-------------------+-------------------+------------+------------
Total       |  14372     |   126.1   4.5     |   190.5   6.8     |      4     | 
 14394


As you can see, the command is processed twice, one second apart, and it even 
has a bug in the summary of the first column: Both tables should read 14372, 
but the first has a wrong value of 14417.

This was not the case in the mldonkey-2.5-4.static.i686-Linux.tar.bz2 I used 
before.

MOW

Follow-up Comments
------------------


-------------------------------------------------------
Date: Sun 05/02/04 at 21:07         By: spiralvoice
Solved with patch 3002

-------------------------------------------------------
Date: Mon 03/01/04 at 21:17         By: spiralvoice
The reason two tables are printed is that the upper shows data about the 
current session, the latter about all sessions. Data is saved to stats.ini and 
will accumulate over the time, so it´s not a bug, it´s a feature.
The reason the numbers are not correct seems to be that there is a client type 
for edonkey servers (Brand_server), which are counted but not displayed. But 
their numbers are calculated into the totals, the patch has to remove those 
numbers from the totals, and has yet to be coded...












For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7965>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/