m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] m4_defn: avoid compiler warning


From: Eric Blake
Subject: [PATCH] m4_defn: avoid compiler warning
Date: Fri, 29 Apr 2011 15:55:41 -0600

argc is an int, therefore by definition, it is <= INT_MAX.

* src/builtin.c (m4_defn): Nuke redundant condition.

Signed-off-by: Eric Blake <address@hidden>
---

The redundant condition was part of an assert added in commit
1029ee26 to silence one gcc warning; now it provoked another
warning.  Oh well.

 ChangeLog     |    3 +++
 src/builtin.c |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 862b516..f007a5d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-04-29  Eric Blake  <address@hidden>

+       m4_defn: avoid compiler warning
+       * src/builtin.c (m4_defn): Nuke redundant condition.
+
        m4_error: fix missing va_end
        * src/m4.c (m4_error, m4_error_at_line): Add missing va_end.

diff --git a/src/builtin.c b/src/builtin.c
index 632ef79..80f2024 100644
--- a/src/builtin.c
+++ b/src/builtin.c
@@ -894,7 +894,7 @@ m4_defn (struct obstack *obs, int argc, token_data **argv)
   if (bad_argc (argv[0], argc, 2, -1))
     return;

-  assert (0 < argc && argc <= INT_MAX);
+  assert (0 < argc);
   for (i = 1; i < (unsigned) argc; i++)
     {
       const char *arg = ARG((int) i);
-- 
1.7.4.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]