m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] Fix build on newer glibc.


From: Eric Blake
Subject: [PATCH 1/2] Fix build on newer glibc.
Date: Fri, 4 Jun 2010 16:08:22 -0600

POSIX allows, but does not require, that <fcntl.h> implicitly
includes <sys/stat.h>.  Until recent glibc, most systems did
this implicit inclusion, and m4 was mistakenly relying on it.

* src/m4.h (includes): Add <sys/stat.h>.
* THANKS: Update.
Reported by Todd Rinaldo.

Signed-off-by: Eric Blake <address@hidden>
---

Wow - it's been a while since I touched m4 (perhaps a good
sign that I'm not finding many bugs in the stable version?)

I've switched over to using 'git send-email' to send these
patch messages; hopefully the new format is easy to understand.

This patch fixes a build issue with newer glibc, so I'll
probably release m4 1.4.15 soon...

 ChangeLog |    7 +++++++
 THANKS    |    1 +
 src/m4.h  |    1 +
 3 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5f8cfaf..d48b7f0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-06-04  Eric Blake  <address@hidden>
+
+       Fix build on newer glibc.
+       * src/m4.h (includes): Add <sys/stat.h>.
+       * THANKS: Update.
+       Reported by Todd Rinaldo.
+
 2010-03-02  Giuseppe Scrivano  <address@hidden>  (tiny change)

        Support bootstrap --gnulib-srcdir=DIR.
diff --git a/THANKS b/THANKS
index f43e2aa..b41887c 100644
--- a/THANKS
+++ b/THANKS
diff --git a/src/m4.h b/src/m4.h
index ccd9936..70dc7a8 100644
--- a/src/m4.h
+++ b/src/m4.h
@@ -32,6 +32,7 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <string.h>
+#include <sys/stat.h>
 #include <sys/types.h>

 #include "binary-io.h"
-- 
1.7.0.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]