m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix -F vs. -t


From: Eric Blake
Subject: Re: fix -F vs. -t
Date: Wed, 24 Oct 2007 18:04:59 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Eric Blake <ebb9 <at> byu.net> writes:

> This core dump has been there for YEARS - basically, since -F was
> introduced in 1994.  It finally bit today:
> http://lists.gnu.org/archive/html/libtool-patches/2007-10/msg00022.html
> 
> Applying this to the branch, and a similar patch to head.
> 
> 2007-10-17  Eric Blake  <ebb9 <at> byu.net>
> 
>       Fix 'm4 -F file -t undefined'.
>       * src/freeze.c (produce_frozen_state): Avoid core dump.
>       * doc/m4.texinfo (Using frozen files): Test for the bug.

This test fails on mingw, which does not have /dev/null.  Bruno recently wrote 
an fopen module for gnulib that fakes /dev/null on mingw, but at this point, 
I'm not sure it's worth importing.  So for now, I'm just skipping the test on 
mingw (I've tested that the feature in question works; the failure was not do 
to miscompilation but due to mingw's difference in NUL vs. /dev/null).

I have not tested mingw with HEAD (nor am I much inclined to do so at this 
time, as there are probably many more unix-specific assumptions in HEAD that 
would also need fixing).  So this patch is just for the branch.  If someone 
reading this list is more interested in mingw than I am, you are welcome to 
contribute patches.  For starters, I still haven't gotten around to patching 
gnulib's strtod module to accept 'inf' and 'nan', so the test for 'eval' is 
still failing because mingw's strtod is deficient.


From: Eric Blake <address@hidden>
Date: Wed, 24 Oct 2007 11:58:47 -0600
Subject: [PATCH] Reduce number of mingw testsuite failures.

* doc/m4.texinfo (Using frozen files): Skip test on mingw.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog      |    5 +++++
 doc/m4.texinfo |    3 +++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c8bc357..1c06340 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2007-10-24  Eric Blake  <address@hidden>
+
+       Reduce number of mingw testsuite failures.
+       * doc/m4.texinfo (Using frozen files): Skip test on mingw.
+
 2007-10-22  Eric Blake  <address@hidden>
 
        Add DEBUG_REGEX debugging information.
diff --git a/doc/m4.texinfo b/doc/m4.texinfo
index 3bece3a..4aea90a 100644
--- a/doc/m4.texinfo
+++ b/doc/m4.texinfo
@@ -6035,6 +6035,9 @@ changed strings for quotes or comments.  And future 
releases of
 
 @comment options: -F /dev/null
 @example
+ifdef(`__unix__', ,
+      `errprint(` skipping: /dev/null not known to exist
+')m4exit(`77')')dnl
 traceon(`undefined')dnl
 @end example
 @end ignore
-- 
1.5.3.2







reply via email to

[Prev in Thread] Current Thread [Next in Thread]