m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: testsuite: distributed depending on non-distributed


From: Eric Blake
Subject: Re: testsuite: distributed depending on non-distributed
Date: Fri, 08 Sep 2006 09:44:16 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5) Gecko/20060719 Thunderbird/1.5.0.5 Mnenhy/0.7.4.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 9/7/2006 7:52 AM:
> According to Ralf Wildenhues on 9/7/2006 7:32 AM:
>>> This change, presumably from a couple of days ago, looks wrong, and
>>> breaks distcheck: a distributed file may not depend on a non distributed
>>> file.  Distributed files should be updated in the source tree.  (These
>>> rules help those that don't want to go crazy with portable make.)
> 
> Phooey - I got it wrong.  I meant for 'make check' to depend on tests/m4
> being up-to-date, not 'make testsuite'.  Fix coming shortly.

With that fixed, and this additional patch, make distcheck works again
when TESTSUITEFLAGS is set to avoid the failing defn test (and on cygwin,
when PATH is set to workaround a libtool issue:
http://www.nabble.com/cygwin-convenience-library--dlpreopen-installation-tf2239271.html#a6210568;
more discussion on that on the libtool list).

2006-09-08  Eric Blake  <address@hidden>

        * bootstrap: Kill unrelated copy-n-paste code from argument
        parsing.  Let Makefile generate testsuite.
        * Makefile.am (EXTRA_DIST): Remove examples/WWW/man/Makefile.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFAY/P84KuGfSFAYARAqBxAJ949N8lxC4gMt3sc687THytzh919wCePFi+
dkd8jU4erg0b3CEFPwoi6JM=
=tIHk
-----END PGP SIGNATURE-----
Index: bootstrap
===================================================================
RCS file: /sources/m4/m4/bootstrap,v
retrieving revision 1.38
diff -u -p -r1.38 bootstrap
--- bootstrap   25 Aug 2006 18:02:17 -0000      1.38
+++ bootstrap   8 Sep 2006 14:17:15 -0000
@@ -1,6 +1,6 @@
 #! /bin/sh
 
-# bootstrap (GNU M4) version 2006-08-25
+# bootstrap (GNU M4) version 2006-09-08
 # Written by Gary V. Vaughan  <address@hidden>
 
 # Copyright (C) 2004, 2005, 2006 Free Software Foundation, Inc.
@@ -226,17 +226,6 @@ func_version ()
     esac
   done
 
-  if test -z "$sendmail_to"; then
-
-    # can't have a from address without a destination address
-    test -n "$sendmail_from" &&
-      func_error "can't use --from without --sendmail." && exit_cmd=exit
-
-    # can't use a signature file without a destination address
-    test -n "$signature_file" &&
-      func_error "can't use --signature without --sendmail." && exit_cmd=exit
-  fi
-
   # Bail if the options were screwed
   $exit_cmd $EXIT_FAILURE
 }
@@ -401,15 +390,9 @@ func_echo "running: AUTOPOINT=true" \
 AUTOPOINT=true $AUTORECONF --force --verbose --install --no-recursive
 
 
-## ---------- ##
-## testsuite. ##
-## ---------- ##
-
-(
-  func_echo "generating testsuite"
-  cd tests
-  $AWK -f ./generate.awk ../doc/m4.texinfo > generated.at
-)
+## ------- ##
+## Wrapup. ##
+## ------- ##
 
 if test x"$DOWNLOAD_PO" != xno; then
   func_echo "If your pofiles are up-to-date, you can rerun bootstrap"
Index: Makefile.am
===================================================================
RCS file: /sources/m4/m4/Makefile.am,v
retrieving revision 1.44
diff -u -p -r1.44 Makefile.am
--- Makefile.am 7 Sep 2006 16:41:24 -0000       1.44
+++ Makefile.am 8 Sep 2006 14:17:15 -0000
@@ -296,7 +296,6 @@ EXTRA_DIST     += \
                  examples/WWW/Makefile \
                  examples/WWW/_footer.htm \
                  examples/WWW/_header.htm \
-                 examples/WWW/man/Makefile \
                  examples/WWW/m4lib/bugs.m4 \
                  examples/WWW/m4lib/changelog.m4 \
                  examples/WWW/m4lib/download.m4 \

reply via email to

[Prev in Thread] Current Thread [Next in Thread]