[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 40a5176 2/6: Improve a comment
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 40a5176 2/6: Improve a comment |
Date: |
Tue, 16 Oct 2018 09:19:09 -0400 (EDT) |
branch: master
commit 40a5176c7b5a2d359672addbeb3616ac63bba171
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Improve a comment
See:
https://lists.nongnu.org/archive/html/lmi/2018-10/msg00036.html
---
pdf_command_wx.cpp | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/pdf_command_wx.cpp b/pdf_command_wx.cpp
index 9d55bfd..6f91a23 100644
--- a/pdf_command_wx.cpp
+++ b/pdf_command_wx.cpp
@@ -1485,10 +1485,18 @@ class numeric_summary_table_cell
m_Height = render_or_measure(0, oe_only_measure);
}
- // Override the base class function to actually render the table.
+ /// Override the base class function to actually render the table.
+ ///
+ /// PDF !! Ideally, the 'x' argument would be passed to
+ /// render_or_measure(), which in turn would pass it to
+ /// create_table_generator(), which would use it instead of
+ /// always using get_horz_margin(). This cannot be asserted:
+ /// LMI_ASSERT(x == mixin_writer_.get_horz_margin());
+ /// because mixin_writer_ is private in this context.
+
void Draw
(wxDC & dc
- ,int x
+ ,int // x
,int y
,int view_y1
,int view_y2
@@ -1496,13 +1504,6 @@ class numeric_summary_table_cell
) override
{
draw_check_precondition(dc, view_y1, view_y2, info);
-
- // The horizontal coordinate is unused, but should always be zero.
- // PDF !! However, it isn't: this assertion fails when the
- // automated GUI test is run.
-// LMI_ASSERT(0 == x);
- (void)&x; // PDF !! Temporary workaround pending investigation.
-
render_or_measure(y + m_PosY, oe_render);
}
- [lmi-commits] [lmi] master updated (3e5ce14 -> 4c21bf7), Greg Chicares, 2018/10/16
- [lmi-commits] [lmi] master 019da5e 3/6: Designate release candidate 20181016T0923Z, Greg Chicares, 2018/10/16
- [lmi-commits] [lmi] master 2b3880b 1/6: Remove a needless "PDF !!" marker, Greg Chicares, 2018/10/16
- [lmi-commits] [lmi] master ee64a21 5/6: Rename a member for concinnity, Greg Chicares, 2018/10/16
- [lmi-commits] [lmi] master 4c21bf7 6/6: Replace shared_ptr with unique_ptr, Greg Chicares, 2018/10/16
- [lmi-commits] [lmi] master 40a5176 2/6: Improve a comment,
Greg Chicares <=
- [lmi-commits] [lmi] master d54ae72 4/6: Replace shared_ptr with unique_ptr, Greg Chicares, 2018/10/16