[Linphone-developers] [patch] Misleading Error Message in alsa.c

[Cameron Barfield]

Howdy --

It's nothing major, but while perusing the changes in 2.1.1 I found a 
mis-leading error
message in alsa_set_params().

If snd_pcm_sw_params_set_stop_threshold() fails, the warning message is "Error 
setting
*start* threshold." I could imagine this causing some headaches...

Regards,
Cameron


--- alsa.c.orig 2008-02-13 10:37:04.000000000 -0800
+++ alsa.c      2008-02-13 10:37:50.000000000 -0800
@@ -142,7 +142,7 @@
                        ms_warning("alsa_set_params: Error setting start 
threshold:%s",snd_strerror(err));
                }
                if ((err=snd_pcm_sw_params_set_stop_threshold(pcm_handle, 
swparams,periodsize*periods ))<0){
-                       ms_warning("alsa_set_params: Error setting start 
threshold:%s",snd_strerror(err));
+                       ms_warning("alsa_set_params: Error setting stop 
threshold:%s",snd_strerror(err));
                }
                if ((err=snd_pcm_sw_params(pcm_handle, swparams))<0){
                        ms_warning("alsa_set_params: Error setting SW 
params:%s",snd_strerror(err));