Re: [Linphone-developers] Patches for oRTP 0.12.0

[Simon Morlat]

Hello Vadim,

Thanks, I've started to review them: huge work !

I 'm not convinced with the first one (split-profiles).
I think it does not make sense since SDP offer/answer model states that the 
answer SHOULD use the same payload numbering as in the offer.
In the case it is not respected you can still use the numbering of the answer, 
which makes your phone compatible with the remote one.
Can you elaborate on this ?

Simon

Le jeudi 14 décembre 2006 20:00, Vadim Lebedev a écrit :
> Hello,
>
> I'm submitting patches for oRtp 0.12.0  for review
>
> 1) split-profiles.patch -- allows setting of different profiles for
> sending/recieving directions
> 2) rtcp-memleak.patch  --  fix a posiible memleak when handling incoming
> rtcp packets
> 3) telephony-events.patch -- genearates better timestamp info for
> telephony events packets, also add handling of FLASH and EVT_[A-D]
> 4) rtptransport.patch - introduces the concept of RtpTransport to allow
> post/pre processing of network data
>
>
> The patches should be applied in order 1 => 4.
>
>
>
> Thanks
> Vadim