Re: [Linphone-developers] SDP handler BUG in coreapi

[Simon Morlat]

Hello,

Thanks a lot for reporting and finding this bug. Actually I found it two days 
ago while I was trying to compile with -Wall -Werror.
Anyway it is fixed in CVS.

Simon

Le Mercredi 15 Juin 2005 11:26, Alex Pepper a écrit :
> I'm using the latest stable version of linphone: 1.0.1, 23 Mar 2005.
> I've found a bug on file coreapi/sdphandler.c, in functions
> sdp_context_read_answer ().
> This bug don't allow sometimes linphone to enable the input/output audio
> stream when one make a call out.
> The code of sdp_context_read_answer () is:
>
> void
> sdp_context_read_answer (sdp_context_t *ctx,char *remote_answer)
> {
>     sdp_message_t *remote;
>     char *mtype, *tmp;
>     char *proto, *port, *pt, *bw;
>     int i, j;
>     int err;
>     sdp_payload_t payload;
>     sdp_handler_t *sdph=ctx->handler;
>
>     sdp_message_init(&remote);
>     sdp_message_parse(remote,remote_answer);
>     if (err<0) {
>         eXosip_trace(OSIP_WARNING,("Could not parse remote offer."));
>         return ;
>     }
>
> ...
>
> As you can see, at line 493 "err" var is used but not initialized
> (declared at line 487).
> As far as I can see, err should be set: err =
> sdp_message_parse(remote,remote_answer); at line 492.
> If err is not set, sometimes, when it's random value is less than 0, the
> function return with error and the audio streaming does not start.
>
> Hope that's help.
>
> Alex.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> _______________________________________________
> Linphone-developers mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/linphone-developers