lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Build slur skyline out of segments rather than boxes. (issue 577820043 b


From: jonas . hahnfeld
Subject: Build slur skyline out of segments rather than boxes. (issue 577820043 by address@hidden)
Date: Sun, 26 Apr 2020 23:52:51 -0700

https://codereview.appspot.com/577820043/diff/555750043/lily/slur.cc
File lily/slur.cc (right):

https://codereview.appspot.com/577820043/diff/555750043/lily/slur.cc#newcode380
lily/slur.cc:380: vector<Box> boxes;
Please move vector<Drul_array<Offset>> segments here and use to for the
early return

https://codereview.appspot.com/577820043/diff/555750043/lily/slur.cc#newcode396
lily/slur.cc:396: if (i)
i > 0 - took me a while to understand that this currently relies on
conversion int->bool

https://codereview.appspot.com/577820043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]