Re: Refactor get/set_property to take the item as first argument (issue 573670043 by address@hidden)

[dak]

On 2020/04/13 23:07:57, Dan Eble wrote:
> This change per se LGTM.  I remember discussing this syntactic change
briefly on
> the list a few(?) months ago, so this is not surprising.
> 
> I'm quite pleased with this change, actually.  I remember how I felt
the first
> time I came across klass->a_macro_actually(...) and couldn't find the
method in
> klass.hh.  I'm glad future contributors will not have to repeat that
experience.

It's embarrassing to admit, but while I did voice something akin to
making macros imitate member function call syntax, I actually forgot
that I had exactly the same kind of somewhat time-consuming double take
when trying to track down that admittedly clever code.

https://codereview.appspot.com/573670043/