Re: Avoid failed assertion in stem tremolo code (issue 572550043 by address@hidden)

[dak]

Thanks for looking at this, Keith!  I've tried to make a version that
does the right thing with regard to the assertion failure.  That does
not address the root cause of the problem, nor does it fix the centering
thing you pointed out.  Quite lacklustre.


https://codereview.appspot.com/572550043/diff/560590043/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (left):

https://codereview.appspot.com/572550043/diff/560590043/lily/stem-tremolo.cc#oldcode182
lily/stem-tremolo.cc:182: ph = ph - ph.center ();
On 2019/04/03 08:16:22, Keith wrote:
> There is the obvious problem that line 182 destroys the effort of line
181.   It
> reports every stem-tremolo to be centered on the central staff-line,
which makes
> line-spacing less accurate but could easily go un-noticed.

This is likely the famous "somebody must have been something"
phenomenon.  Since this does not concern the segfaulting, I am leaving
this for someone else to fix.  Ok, I'll add a TODO.

https://codereview.appspot.com/572550043/