Re: Fixx #3314 : use superscript for powerChordSymbol (issue 348060043 by address@hidden)

[dak]

message: On 2018/12/13 12:26:07, Valentin Villenave wrote:

https://codereview.appspot.com/348060043/diff/1/ly/chord-modifiers-init.ly
> File ly/chord-modifiers-init.ly (right):


https://codereview.appspot.com/348060043/diff/1/ly/chord-modifiers-init.ly#newcode49
> ly/chord-modifiers-init.ly:49: <c g>1-\markup { \super "5" }
> On 2018/12/13 11:32:34, dak wrote:
> > The way this is arranged currently, it reads jarringly.

> I agree, there are a few things that look quite bad: among others,
> \partialJazzMusic should be rewritten (and its use is hardly
documented);
> there’s a TODO line 534 in chord.itely that should be addressed;
> Documentation/included/chord-names-jazz.ly should be entirely
rewritten by
> taking advantage of predefined exception lists rather than duplicating
lots of
> stuff; "banter-chord-names" isn’t documented anywhere and looks
deprecated
> anyway; and there are a bunch of regtests that have been scrapped over
the
> years.

> Since I don’t know much about all of these and was reluctant to open
that
> particular can of worms, I was merely aiming for the low-hanging
fruits here :-)

Putting the change up where it does not look out of place _is_
low-hanging fruit.  The reason this was kept the way it was most likely
is because the change looked out of place.  Moving it among its kind
would fix that.  That's a maintainability issue making the difference
between people daring to touch things and not (as it has proven to be by
the long history of the issue if nothing else).  So I don't really get
the "we could do more, so let's do less" argument here.

https://codereview.appspot.com/348060043/