|
From: | tdanielsmusic |
Subject: | Re: Doc: Added \compoundMeter function to NR (issue4837050) |
Date: | Sun, 07 Aug 2011 15:24:44 +0000 |
Almost there - a couple of comments ... http://codereview.appspot.com/4837050/diff/15001/Documentation/music-glossary.tely File Documentation/music-glossary.tely (right): http://codereview.appspot.com/4837050/diff/15001/Documentation/music-glossary.tely#newcode2114 Documentation/music-glossary.tely:2114: \compoundMeter #'((3 8) (2 8) (4 8)) \compoundMeter #'((3 8) (2 8) (3 8)) http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1546 Documentation/notation/rhythms.itely:1546: @code{\scaleDurations} function in each staff to the common time ... function to scale the durations of the notes in each staff ... http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1555 Documentation/notation/rhythms.itely:1555: shown durations are multiplied by 3/5 -- as 3/5 * 10/8 = 3/4. It may be I prefer brackets to show these parenthetical comments: (because 2/3 * 9/8 = 3/4) http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1643 Documentation/notation/rhythms.itely:1643: come before it indicate the beat value. I think it's clearer to say top and bottom of the time signature: ... last number in the list is placed at the bottom of the time signature and the numbers that come before it are placed as a summation at the top. All but the last number indicate the stress groupings and sum to the duration of the measure. http://codereview.appspot.com/4837050/
[Prev in Thread] | Current Thread | [Next in Thread] |