[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one wit
From: |
Thomas Schmitt |
Subject: |
[Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files |
Date: |
Sat, 29 Dec 2018 17:00:35 +0100 |
Hi,
i now get plausible output from cd-info.c.
Fixes were needed in
lib/driver/image/bincue.c
lib/driver/image_common.c
and also the fix of src/cd-info.c in Edd Barrett's branch
https://github.com/vext01/libcdio/tree/openbsd_fixes_to_master_for_merge
>From .cue file
FILE "cdda.bin" BINARY
TRACK 04 AUDIO
FLAGS DCP
INDEX 01 00:00:00
TRACK 05 AUDIO
FLAGS DCP
INDEX 01 00:02:00
i now get this cd-info track list:
Disc mode is listed as: CD-DA
CD-ROM Track List (4 - 5)
#: MSF LSN Type Green? Copy? Channels Premphasis?
4: 00:02:00 000000 audio false yes 2 no
5: 00:04:00 000150 audio false yes 2 no
170: 00:06:02 000302 leadout (693 KB raw, 693 KB formatted)
Media Catalog Number (MCN): not available
Last CD Session LSN: not supported by drive/driver
audio status: not implemented
The difference in MSF comes from CDIO_PREGAP_SECTORS = 150 = 00:02:00.
(I.e. the MSF of CUE file format and CD TOC differ by 2 seconds.)
----------------------------------------------------------------------------
I only committed bincue.c and image_common.c in order not to disturb the
pull request by Edd:
http://git.savannah.gnu.org/cgit/libcdio.git/commit/?h=trackno-higher-one&id=7b6139933e9665126886ddac4f9e68f47931104b
My fixes may well help to get his .cue test to work.
(I am glad that i do not have to manage this situation on Edd's side.)
----------------------------------------------------------------------------
Open question to be decided before merging:
If i submit a CUE file with wrong track numbers i only get to see
**ERROR: source name data/cdda_track_4_5.cue is not recognized as a CUE file
but not the cdio_log() messages of level CDIO_LOG_INFO, despite i used
option -d2 with cd-info.
So for now i issue the track number complaints as warnings. But many other
reasons for refusal would stay invisible.
Is there a way to influence variable cdio_loglevel_default ?
In that case i would reduce the level from warning to info.
----------------------------------------------------------------------------
Have a nice day :)
Thomas
- [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files,
Thomas Schmitt <=
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Edd Barrett, 2018/12/29
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Edd Barrett, 2018/12/29
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Thomas Schmitt, 2018/12/29
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Edd Barrett, 2018/12/29
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Rocky Bernstein, 2018/12/29
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Thomas Schmitt, 2018/12/30
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Rocky Bernstein, 2018/12/30
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Edd Barrett, 2018/12/30
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Thomas Schmitt, 2018/12/30
- Re: [Libcdio-devel] Ready for testing: libcdio branch trackno-higher-one with .cue files, Rocky Bernstein, 2018/12/30