Re: Changes to `make-obsolete` and similar functions make upgrades nearly impossible.

[Ruijie Yu]

Lloyd Zusman <hippoman@potamuses.net> writes:

> I'm a very long-term GNU emacs user: since the 1980's.
>
> I have been using numerous elisp packages, lots of which date
> back many years, and a few of my own elisp modules go all the
> way back to the 1980's.
>
> I have been using emacs-27.2 for a few years, and now I decided
> to upgrade again. However, when going to emacs-28.2, I hit an
> issue with the following emacs enhancement (this comes from the
> emacs change log):
>
>> 2021-01-03  Stefan Monnier  <monnier@iro.umontreal.ca>
>>
>>        * lisp/emacs-lisp/byte-run.el (make-obsolete): Make `when` mandatory
>>
>>        (define-obsolete-function-alias, make-obsolete-variable)
>>        (define-obsolete-variable-alias): Adjust similarly.
>
> Because of `when` becoming mandatory, I now get literally hundreds
> of messages which look like this when starting up emacs-28.2 ...
>
>> Warning (comp): /path/to/some-elisp-module.el: Error: Wrong number of 
>> arguments make-obsolete-variable

Would it work if you place a `:filter-args' advice on
`make-obsolete-variable', inside early-init.el or something even earlier
(not sure if one exists)?  I am not sure what the effects would be if
you byte-compile or native-compile, but loading sources directly _might_
work?

-- 
Best,


RY

[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- still investigating.]