01/02: build-system/python: Move the check phase after the install phase.

[guix-commits]

apteryx pushed a commit to branch core-updates
in repository guix.

commit 6bbb37a545912c6bb2513ee08587ee4fe39cc330
Author: Maxim Cournoyer <address@hidden>
Date:   Wed Apr 3 00:09:20 2019 -0400

    build-system/python: Move the check phase after the install phase.
    
    A reproducibility problem was discovered while packaging python-pygithub 
where
    the bytecode produced by running the tests would interfere with the result 
of
    the install phase byte compilation.  Moving the check phase after the 
install
    phase solves the problem.
    
    * guix/build/python-build-system.scm (%standard-phases): Add comment, move
    the check phase after the install phase.
---
 guix/build/python-build-system.scm | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/guix/build/python-build-system.scm 
b/guix/build/python-build-system.scm
index 73b554c..7c00306 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -250,16 +250,21 @@ installed with setuptools."
   #t)
 
 (define %standard-phases
-  ;; 'configure' phase is not needed.
+  ;; The build phase only builds C extensions and copies the Python sources,
+  ;; while the install phase byte-compiles and copies them to the prefix
+  ;; directory.  The tests are run after the install phase because otherwise
+  ;; the cached .pyc generated during the tests execution seem to interfere
+  ;; with the byte compilation of the install phase.
   (modify-phases gnu:%standard-phases
     (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980)
     (add-after 'ensure-no-mtimes-pre-1980 'enable-bytecode-determinism
       enable-bytecode-determinism)
     (delete 'bootstrap)
-    (delete 'configure)
-    (replace 'install install)
-    (replace 'check check)
+    (delete 'configure)                 ;not needed
     (replace 'build build)
+    (delete 'check)                     ;moved after the install phase
+    (replace 'install install)
+    (add-after 'install 'check check)
     (add-after 'install 'wrap wrap)
     (add-before 'strip 'rename-pth-file rename-pth-file)))