[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] ieee1275: Null pointer dereference in grub_ieee1275_encode_devna
From: |
Eric Snowberg |
Subject: |
[PATCH] ieee1275: Null pointer dereference in grub_ieee1275_encode_devname |
Date: |
Tue, 2 Apr 2019 09:40:31 -0700 |
Function grub_strndup may return NULL, this is called from function
grub_ieee1275_get_devname which is then called from function
grub_ieee1275_encode_devname to set device. The device variable
could then be used with a NULL pointer.
Signed-off-by: Eric Snowberg <address@hidden>
---
grub-core/kern/ieee1275/openfw.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/grub-core/kern/ieee1275/openfw.c b/grub-core/kern/ieee1275/openfw.c
index 62929d9..4d493ab 100644
--- a/grub-core/kern/ieee1275/openfw.c
+++ b/grub-core/kern/ieee1275/openfw.c
@@ -479,6 +479,9 @@ grub_ieee1275_encode_devname (const char *path)
char *optr;
const char *iptr;
+ if (! device)
+ return 0;
+
encoding = grub_malloc (sizeof ("ieee1275/") + 2 * grub_strlen (device)
+ sizeof (",XXXXXXXXXXXX"));
if (!encoding)
--
1.7.1
- [PATCH] ieee1275: Null pointer dereference in grub_ieee1275_encode_devname,
Eric Snowberg <=