[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] Upgrade Gnulib; switch to bootstrap tool
From: |
Colin Watson |
Subject: |
Re: [PATCH 1/1] Upgrade Gnulib; switch to bootstrap tool |
Date: |
Wed, 27 Feb 2019 10:02:01 +0000 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
(Sorry for the slow response.)
On Wed, Jan 16, 2019 at 09:03:40PM +0100, Daniel Kiper wrote:
> Could you update INSTALL file too?
Done.
> Additionally, if you do such huge change could you move Gnulib from
> grub-core/gnulib to grub-core/lib/gnulib?
Ending up with grub-core/lib/gnulib/libgnu.a seems pretty repetitive,
but on the other hand it does keep gnulib together with other
(semi-)autogenerated things like libgcrypt, so OK.
> Including all diffs which are currently outside of grub-core/gnulib
> directory. Well, maybe *.diff files should be renamed to *.patch...
These can't be in grub-core/lib/gnulib/; that whole directory should be
regarded as being wiped out by gnulib-tool (it may not in fact be, but
in my experience it's best to keep manually-maintained files separate
from the directory that you give to gnulib-tool --source-base=). I
agree that they should be collected in their own directory though. I've
moved them to grub-core/lib/gnulib-patches/ instead, and renamed to
.patch as you suggest.
> Could you add to the commit message how to exactly update Gnulib?
> Just list of steps like in the commit 461f1d8af (Import upstream
> zstd-1.3.6).
Commit messages aren't a good place for this sort of thing. (I mean,
they're better than nothing, but they're still not great.) I've updated
docs/grub-dev.texi instead, adding a "Gnulib" section under a new
"Updating external code" chapter. I hope this will encourage people who
know about the other bits of external code that GRUB imports to add
corresponding sections there.
I'll send a v2.
Thanks,
--
Colin Watson address@hidden
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 1/1] Upgrade Gnulib; switch to bootstrap tool,
Colin Watson <=