grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grub-install: check for arm-efi as a default target


From: Leif Lindholm
Subject: Re: [PATCH] grub-install: check for arm-efi as a default target
Date: Tue, 26 Feb 2019 13:27:21 +0000
User-agent: NeoMutt/20170113 (1.7.2)

On Thu, Feb 21, 2019 at 04:31:32PM +0100, Daniel Kiper wrote:
> On Thu, Feb 21, 2019 at 03:04:26PM +0000, Leif Lindholm wrote:
> > On Thu, Feb 21, 2019 at 02:46:11PM +0000, Steve McIntyre wrote:
> > > Much like on x86, we can work out if the system is running on top of
> > > EFI firmware. If so, return "arm-efi". If not, fall back to
> > > "arm-uboot" as previously.
> > >
> > > Split out the code to (maybe) load the efivar module and check for
> > > /sys/firmware/efi into a common helper routine is_efi_system()
> > >
> > > Signed-off-by: Steve McIntyre <address@hidden>
> >
> > LGTM:
> > Reviewed-by: Leif Lindholm <address@hidden>
> 
> Reviewed-by: Daniel Kiper <address@hidden>
> 
> If there are no objections I will push this patch next week.

Eep.

As pointed out by Colin on IRC - it appears you have pushed Steves
original submission rather than the revised one which I gave my R-b
for.

Could you address?

Regards,

Leif



reply via email to

[Prev in Thread] Current Thread [Next in Thread]