Re: [PATCH v4] Add travis-ci config file

[Alexander Graf]

On 22.02.19 14:22, Daniel Kiper wrote:
> On Fri, Feb 22, 2019 at 09:17:46AM +0100, Alexander Graf wrote:
>> There is a really convenient service for open source project from Travis
>> CI: They allow for free CI testing using their infrastructure.
>>
>> Grub has had issues with broken builds for various targets for a long time
>> already. The main reason is a lack of CI to just do smoke tests on whether
>> all targets still at least compile.
>>
>> This patch adds a travis config file which builds (almost) all currently
>> available targets.
>>
>> On top of that, this travis config also runs a small execution test on the
>> x86_64-efi target.
>>
>> All of this config file can easily be extended further on. It probably makes
>> sense to do something similar to the u-boot test infrastructure that
>> communicates with the payload properly. Going forward, we also will want to
>> do more qemu runtime checks for other targets.
>>
>> Currently, with this config alone, I already see about half of the available
>> targets as broken. So it's definitely desperately needed :).
>>
>> Signed-off-by: Alexander Graf <address@hidden>
> 
> In general Reviewed-by: Daniel Kiper <address@hidden>
> 
> But...
> 
>> ---
>>
>> v1 -> v2:
>>
>>   - Fix comment about toolchain variable
>>
>> v2 -> v3:
>>
>>   - s/grub/GRUB/
>>   - remove unneeded packages
>>   - comment fixes
>>   - determine number of jobs dynamically
>>   - sort targets alphabetically
>>
>> v3 -> v4:
>>
>>   - reduce package list futher
>>   - sort package list alphabetically
>> ---
>>  .travis.yml | 109 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 109 insertions(+)
>>  create mode 100644 .travis.yml
>>
>> diff --git a/.travis.yml b/.travis.yml
>> new file mode 100644
>> index 000000000..a66143cba
>> --- /dev/null
>> +++ b/.travis.yml
>> @@ -0,0 +1,109 @@
>> +# SPDX-License-Identifier: GPL-3.0+
>> +# Originally Copyright Roger Meier <address@hidden>
>> +# Adapted for GRUB by Alexander Graf <address@hidden>
>> +
>> +# build GRUB on Travis CI - https://travis-ci.org/
>> +
>> +dist: xenial
>> +
>> +language: c
>> +
>> +addons:
>> +  apt:
>> +    packages:
>> +    - build-essential
>> +    - device-tree-compiler
> 
> Out of curiosity, are build-essential and device-tree-compiler needed to
> test GRUB or just leftovers by mistake?

I think build-essential is a nop (already installed) and
device-tree-compiler an oversight.

Off to v5 ...


Alex