Re: [PATCH] arm: Move initrd upper to leave more space for kernel

[Alexander Graf]

> Am 01.02.2019 um 12:19 schrieb Leif Lindholm <address@hidden>:
> 
> On Fri, Feb 01, 2019 at 11:46:14AM +0100, Daniel Kiper wrote:
>>> diff --git a/include/grub/arm/linux.h b/include/grub/arm/linux.h
>>> index 712ba17b9..d0b24d474 100644
>>> --- a/include/grub/arm/linux.h
>>> +++ b/include/grub/arm/linux.h
>>> @@ -42,7 +42,7 @@ struct linux_arm_kernel_header {
>>> #if defined GRUB_MACHINE_UBOOT
>>> # include <grub/uboot/uboot.h>
>>> # define LINUX_ADDRESS        (start_of_ram + 0x8000)
>>> -# define LINUX_INITRD_ADDRESS (start_of_ram + 0x02000000)
>>> +# define LINUX_INITRD_ADDRESS (start_of_ram + 0x03000000)
>>> # define LINUX_FDT_ADDRESS    (LINUX_INITRD_ADDRESS - 0x10000)
>>> # define grub_arm_firmware_get_boot_data grub_uboot_get_boot_data
>>> # define grub_arm_firmware_get_machine_type grub_uboot_get_machine_type
>>> @@ -50,7 +50,7 @@ struct linux_arm_kernel_header {
>>> #include <grub/fdtbus.h>
>>> #include <grub/arm/coreboot/kernel.h>
>>> # define LINUX_ADDRESS        (start_of_ram + 0x8000)
>>> -# define LINUX_INITRD_ADDRESS (start_of_ram + 0x02000000)
>>> +# define LINUX_INITRD_ADDRESS (start_of_ram + 0x03000000)
>>> # define LINUX_FDT_ADDRESS    (LINUX_INITRD_ADDRESS - 0x10000)
>>> static inline const void *
>>> grub_arm_firmware_get_boot_data (void)
>> 
>> LGTM, however, I would like to hear Alex's and/or Leif's (CC-ed) opinion
>> about theses changes.

Heh, I suggested it :).

> 
> I don't see an issue with it. (Only platforms likely to be affected
> would be ones with very little RAM and large initrds.)
> 
> However, I would like to point out that U-Boot builds with the UEFI
> interface enabled can use the arm-efi platform instead, and would then
> not be suffering from this issue to start with.

We are actually booting with atm-efi, but then have grub boot using the legacy 
protocol atm. The plan is to move to a native efi boot path further down the 
road.

Either way:

Acked-by: Alexander Graf <address@hidden>


Alex