groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [tests]: Tolerate U register defaulting to 1.


From: G. Branden Robinson
Subject: Re: [PATCH] [tests]: Tolerate U register defaulting to 1.
Date: Tue, 11 Jul 2023 14:05:22 -0500

At 2023-07-11T17:57:08+0100, Colin Watson wrote:
> If tmac/man.local is patched to set the U register to 1, then one test
> fails.  That test is concerned specifically with the rendering of long
> URLs when they are not turned into OSC 8 hyperlinks, so it makes sense
> to disable OSC 8 hyperlinks for that test.
> 
> * tmac/tests/an_UE-breaks-before-long-URIs.sh: Run groff with -rU0.

This is a good catch; thanks, Colin.  A year ago or more, I probably had
in mind to leave the test as-is, but discovered some complexities around
tagging and URLs.

https://savannah.gnu.org/bugs/index.php?61434
https://savannah.gnu.org/bugs/index.php?62060

And while looking at a different sort of tag, which might include the
paragraph kind:

https://savannah.gnu.org/bugs/index.php?62182

So there is some work to be done here and your change will be necessary
for a while.

Regards,
Branden

> ---
>  tmac/tests/an_UE-breaks-before-long-URIs.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tmac/tests/an_UE-breaks-before-long-URIs.sh 
> b/tmac/tests/an_UE-breaks-before-long-URIs.sh
> index 0b151fd8d..f39ceaea1 100755
> --- a/tmac/tests/an_UE-breaks-before-long-URIs.sh
> +++ b/tmac/tests/an_UE-breaks-before-long-URIs.sh
> @@ -48,10 +48,10 @@ wail () {
>      fail=yes
>  }
>  
> -output=$(printf "%s" "$input" | "$groff" -Tascii -P-cbou -man)
> +output=$(printf "%s" "$input" | "$groff" -Tascii -P-cbou -rU0 -man)
>  echo "$output"
>  error=$(printf "%s" "$input" \
> -    | "$groff" -Tascii -P-cbou -man -ww -z 2>&1)
> +    | "$groff" -Tascii -P-cbou -rU0 -man -ww -z 2>&1)
>  
>  echo "testing that no diagnostic messages are produced" >&2
>  test -z "$error" || wail
> -- 
> 2.39.2
> 

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]