[groff] 12/17: [troff]: Trivially refactor.

[G. Branden Robinson]

gbranden pushed a commit to branch master
in repository groff.

commit 9d245c4a2e313923e6e9e274740aa5a45828feae
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sat Aug 5 10:27:39 2023 -0500

    [troff]: Trivially refactor.
    
    * src/roff/troff/input.cpp (input_char_description): Migrate to
      `const`-qualified object to size an array of length computed at
      compile time and avoid repeating lengthy expression.
---
 ChangeLog                | 8 ++++++++
 src/roff/troff/input.cpp | 5 ++---
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index de72ac7ba..9e541cacc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2023-08-05  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       [troff]: Trivially refactor.
+
+       * src/roff/troff/input.cpp (input_char_description): Migrate to
+       `const`-qualified object to size an array of length computed at
+       compile time and avoid repeating lengthy expression.
+
 2023-08-04  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [tbl]: Fix staggering of text block cells.
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index c2d4238f9..7ff890054 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -6770,9 +6770,8 @@ const char *input_char_description(int c)
   case '\0':
     return "a node";
   }
-  size_t bufsz = sizeof "magic character code " + INT_DIGITS + 1;
-  // repeat expression; no VLAs in ISO C++
-  static char buf[sizeof "magic character code " + INT_DIGITS + 1];
+  const size_t bufsz = sizeof "magic character code " + INT_DIGITS + 1;
+  static char buf[bufsz];
   (void) memset(buf, 0, bufsz);
   if (is_invalid_input_char(c)) {
     const char *s = asciify(c);