[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.11-238
From: |
Eric S. Raymond |
Subject: |
[gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.11-238-ga377b9d |
Date: |
Fri, 23 Jan 2015 10:00:20 +0000 |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GPSD".
The branch, master has been updated
via a377b9ddf35113f328f1291bcff6db539d11eaf4 (commit)
via 3eac4ce1ea05e08d75a27e09eaccf571d5fb45dc (commit)
via 822cf84c9f93398befe3c19137a46207383254b6 (commit)
via 8ad7639727312ec64d989bb911babe8ae01f469d (commit)
from 78c5fe3fe60be3645e080ff14c5c843c811c82da (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a377b9ddf35113f328f1291bcff6db539d11eaf4
Author: Matt <address@hidden>
Date: Fri Jan 23 19:29:47 2015 +1100
Add do { ... } while (0) around assignment in macro
Add the customary do { ... } while (0) around this macro which expands
to executable code (as opposed to an expression).
I believe this is not necessary when, as in this case, the code is a
single line.
But a) it costs nothing, b) it might become multi-line one day, and c)
it looks wrong to my C programmer eyes - alarm bells ring every time I
read it, and I don't want to blunt that generally healthy reaction.
commit 3eac4ce1ea05e08d75a27e09eaccf571d5fb45dc
Author: Matt <address@hidden>
Date: Fri Jan 23 19:29:04 2015 +1100
Guard NTPSHM-related declarations
These functions aren't called if ntpshm support is disabled, so there's
no need to declare them.
Fixes the following warning seen on cygwin with ntpshm disabled:
In file included from gpsutils.c:22:0:
gpsd.h:1215:80: warning: 'struct shmTime' declared inside parameter list
extern int ntpshm_put(struct gps_device_t *, volatile struct shmTime
*, struct timedrift_t *);
^
gpsd.h:1215:80: warning: its scope is only this definition or
declaration, which is probably not what you want
commit 822cf84c9f93398befe3c19137a46207383254b6
Author: Matt <address@hidden>
Date: Fri Jan 23 19:28:36 2015 +1100
Guard includes of termios.h with #ifdef HAVE_TERMIOS_H
Guard includes of termios.h with #ifdef HAVE_TERMIOS_H.
Test for termios.h in scons, and define/undefine HAVE_TERMIOS_H accordingly.
Fixes the below error seen on cygwin, which lacks termios.h:
In file included from gpsutils.c:22:0:
gpsd.h:349:21: fatal error: termios.h: No such file or directory
#include <termios.h>
^
commit 8ad7639727312ec64d989bb911babe8ae01f469d
Author: Matt <address@hidden>
Date: Fri Jan 23 19:25:00 2015 +1100
Move pointer the correct direction when trying to skip spaces
gpsd_set_century attempts to skip optional whitespace in its input, but
it does so by decrementing its pointer, when it should instead be
incrementing it.
Eric, I feel this one should make the snap release. It's trivial,
isolated from other code, and I hope is "obviously correct".
I have further patches in my queue, which I'm sending shortly, but which
I don't think should necessarily go in the current snap release. None of
them is critical.
-----------------------------------------------------------------------
Summary of changes:
SConstruct | 5 +++++
gps.h | 2 +-
gps2udp.c | 5 +++++
gpsd.h-tail | 6 ++++--
gpspipe.c | 4 ++++
timebase.c | 2 +-
6 files changed, 20 insertions(+), 4 deletions(-)
hooks/post-receive
--
GPSD
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.11-238-ga377b9d,
Eric S. Raymond <=