[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: latest release of gui and giflib > 5.1.0
From: |
Fred Kiefer |
Subject: |
Re: latest release of gui and giflib > 5.1.0 |
Date: |
Mon, 25 May 2015 20:40:55 +0200 |
Thank you for spotting this. This is a rather annoying bug. One of the main
reasons why I tried to push the new release out was to get GIF support working
again with a current release of libgif and now this is still broken.
If you change this, could you please move the #define for EGifOpen to the
beginning of the file as well, to keep things more consistent.
What I don't understand is why I did not see a compiler warning on the OBS for
openSUSE Factory.
Fred
On the road
Am 25.05.2015 um 19:40 schrieb Sebastian Reitenbach <address@hidden>:
> Hi,
>
> while upgrading the latest releases, I ran into problem with the libgif 5.1.1
> installed on OpenBSD, that EGifCloseFile() is called with too few
> arguments. Seems with 5.1.0, it got added the second argument, like
> DGifClose got, patch below fixes issue for me.
>
> OK to commit?
>
>
>
> --- Source/NSBitmapImageRep+GIF.m.orig Mon May 25 19:30:24 2015
> +++ Source/NSBitmapImageRep+GIF.m Mon May 25 19:30:40 2015
> @@ -64,6 +64,7 @@ objective-c headers.
> // GIF> 5.1
> #if GIFLIB_MAJOR >= 5 && GIFLIB_MINOR >= 1
> #define DGifCloseFile(f) DGifCloseFile(f, NULL)
> + #define EGifCloseFile(f) EGifCloseFile(f, NULL)
> #endif
>
> /* -----------------------------------------------------------
>
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/gnustep-dev