Re: [Gnustep-cvs] gnustep/dev-libs/gdl2 ChangeLog EOAccess/EOAttr...

[David Ayers]

Manuel Guesdon wrote:

> CVSROOT:      /cvsroot/gnustep
> Module name:  gnustep
> Branch:       
> Changes by:   Manuel Guesdon <address@hidden> 05/04/24 11:28:15
> 
> Modified files:
>       dev-libs/gdl2  : ChangeLog 
>       dev-libs/gdl2/EOAccess: EOAttribute.m 
>       dev-libs/gdl2/EOControl: EOPrivate.h EOKeyValueArchiver.m 
> 
> Log message:
>       Fixes inEOAttribute.m and EOKeyValueARchiver.m
> 

===================================================================
RCS file:
/cvsroot/gnustep/cvsroot/gnustep/gnustep/dev-libs/gdl2/EOAccess/EOAttribute.m,v
...
+            if(_valueFactoryMethod != NULL)
+              {
+                NSData* tmp = value;
+                // valueFactoryMethod returns an autoreleased value
+                value = [(id)valueClass performSelector:
_valueFactoryMethod
+                           withObject: value];
+                if (value != value)

===> I think you wanted 'value != tmp' here.

+                  {
+                    RETAIN(value);
+                    RELEASE(tmp);
+                  };
+              };

The rest looks good.  Hopefully I can write some tests soon.

Thanks,
David