|
From: | Nutchanon Wetchasit |
Subject: | [Gnash-commit] [patch #8715] Patch for fixing callback registration issue in ExternalInterface |
Date: | Thu, 13 Aug 2015 16:25:33 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0 |
URL: <http://savannah.gnu.org/patch/?8715> Summary: Patch for fixing callback registration issue in ExternalInterface Project: Gnash - The GNU Flash player Submitted by: nachanon Submitted on: Thu 13 Aug 2015 11:25:32 PM ICT Category: core Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any _______________________________________________________ Details: Patch 1 of 2. See the attached `0001_fix-externalinterface-callback-registration.patch`. This patch fixes following ExternalInterface issues listed on bug #37223: * `method` argument was ignored; Gnash called `_root.methodName` instead. * Registration failed silently if `instance` argument is `null` or `undefined`. * Gnash only passed maximum 3 arguments to the callback; specifiying more than 3 would have same result as passing 0 argument. I also took a liberty of adding Doxygen documentation on the newly-updated `movie_root::addExternalCallback()` too. This patch might need a review before I submit the second one, as I didn't know much about Gnash's internal GC mechanism. (I just used `as_object.setReachable()` after storing Function in `std::vector`, and did nothing when the callback got replaced in `std::vector`) Gnash: 0.8.11dev (patched against git 6b269f9 24-May-2015) NPAPI Browser: Iceweasel 10.0.12 (debian) System: Debian GNU/Linux 7.0 Wheezy i386 _______________________________________________________ File Attachments: ------------------------------------------------------- Date: Thu 13 Aug 2015 11:25:33 PM ICT Name: 0001_fix-externalinterface-callback-registration.patch Size: 5kB By: nachanon Patch for fixing ExternalInterface callback registration <http://savannah.gnu.org/patch/download.php?file_id=34635> _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/patch/?8715> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |