Re: [Gnash-commit] gnash ChangeLog testsuite/misc-swfc.all/opcode_...

[zou lunkai]

> Safe for what ?
m_target shouldn't be a hard reference, especially when it is the 'top
of the scope chain'.

--zou

On 10/12/07, strk <address@hidden> wrote:
> On Fri, Oct 12, 2007 at 01:12:04AM +0000, Zou Lunkai wrote:
> > CVSROOT:      /sources/gnash
> > Module name:  gnash
> > Changes by:   Zou Lunkai <zoulunkai>  07/10/12 01:12:04
> >
> > Modified files:
> >       .              : ChangeLog
> >       testsuite/misc-swfc.all: opcode_guard_test2.sc
> >
> > Log message:
> >       * testsuite/misc-swfc.all/opcode_guard_test2.sc: test that both 
> > setTarget
> >         and setTargetExpression use the target string instead of pointer for
> >         searching the target. From this point, keep the 
> > as_environment::m_target as a
> >         string type should be safe, does it?
>
> Safe for what ? If you're thinkin about m_target as a soft-ref I tried it and
> doesn't do what we want. The m_target concept will be changed radically with
> the new VM. It's likely the 'top of scope stack' we need, which needs to be
> decoupled by the 'with stack' (currently it's the same).
>
> --strk;
>
>