Re: [gcmd-dev] [PATCH] Set correct window type hint for the rename dialog

[Thomas Jost]

On Mon, 22 Nov 2010 08:04:04 +0100, Piotr Eljasiak <address@hidden> wrote:
> > > I've just reverted the patch in the repos, as it caused problems with
> > > correct displaying rename box (F2 or SHIFT+F6) in metacity.
> > 
> > not in wmaker though
> 
> Sorry for being imprecise - the rename entry couldn't be closed with
> either ESC or ENTER and stayed always-on-top till gcmd exit.

I installed a VM with Gnome so that I can test this. And yep, setting
the window type hint to UTILITY triggers this bug.

Setting it to DIALOG (...which makes sense for a GnomeCmdRenameDialog)
fixes this for me, both in Gnome and Awesome. The patch is attached to
this mail.

If this does not break for other WMs (wmaker, kwin, xfce's WM...), could
you please commit this?

Regards,

-- 
Thomas/Schnouki

pgpN8dhGvKnBk.pgp
Description: PGP signature

diff --git a/src/gnome-cmd-rename-dialog.cc b/src/gnome-cmd-rename-dialog.cc
index 21438a9..bac6098 100644
--- a/src/gnome-cmd-rename-dialog.cc
+++ b/src/gnome-cmd-rename-dialog.cc
@@ -151,6 +151,7 @@ GtkWidget *gnome_cmd_rename_dialog_new (GnomeCmdFile *f, 
gint x, gint y, gint wi
     gtk_window_set_decorated (GTK_WINDOW (dialog), 0);
     gtk_widget_set_uposition (GTK_WIDGET (dialog), x, y);
     gtk_window_set_skip_taskbar_hint (GTK_WINDOW (dialog), TRUE);
+    gtk_window_set_type_hint (GTK_WINDOW (dialog), 
GDK_WINDOW_TYPE_HINT_DIALOG);
 
     gtk_widget_set_size_request (GTK_WIDGET (dialog), width+1, height+1);
     dialog->priv->textbox = GTK_ENTRY (gtk_entry_new ());