[gcmd-dev] Other critical error from argentine

[Martin Riarte]

Hi friends...:

Thanks by accept my humble contribution, this gives me more desire to 
continue, as I did the mistake of menus, use the terminal to run 
GNOME-Commander and view the properties of a file and then exit the 
properties dialog, in the terminal displays the following error:

GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed

In the gnome-cmd-file-props-dialog.cc source file, calc_tree_size_func 
function, appears:

   g_source_remove (data->updater_proc_id); // always remove

    if (data->thread)
        g_thread_join (data->thread);

(Solution) before using the function g_source_remove, see if 
"data->updater_proc_id" in the function "join_thread_func" 
(gnome-cmd-file-props-dialog.cc file) has a value greater than 0:

   if (data->updater_proc_id)
       g_source_remove (data->updater_proc_id); // removed if the 
condition is accepted
   
    if (data->thread)
        g_thread_join (data->thread);

The error does not occur again, and in my tests I feel more stable, but 
I'd like to try it out and tell me if it affects other components in a 
negative way so that the solution would not work, right?
I have attached the patch and thanks again for to assist me :-).

PD:
I like the project and I like the attention paid, but I have seen many 
errors that have persisted over time since the release of version 1.2.8, 
are in need of more collaborators? ...
If so, with your permission divulge the project from the company where I 
work so that other programmers know what ;-).

--- gnome-commander-1.2.8.7/src/gnome-cmd-file-props-dialog.cc  2010-07-27 
15:45:17.000000000 -0300
+++ 
gnome-commander-1.2.8.7/src/gnome-cmd-file-props-dialog.cc.fix-g_source_remove  
    2010-08-04 21:00:18.000000000 -0300
@@ -141,7 +141,8 @@ static void calc_tree_size_func (GnomeCm
 // Tells the thread to exit and then waits for it to do so.
 static gboolean join_thread_func (GnomeCmdFilePropsDialogPrivate *data)
 {
-    g_source_remove (data->updater_proc_id);
+    if (data->updater_proc_id)
+        g_source_remove (data->updater_proc_id);
     
     if (data->thread)
         g_thread_join (data->thread);