[gcmd-dev] gnome-commander crashes ...

[Jens Rehsack]

Hi Piotr,

last time I played (means: not working, just jumping a bit around in 
home-dir and doing some various actions) a bit around with gnome-commander 
before 1.2.7 were released I get it crashed once but didn't detect what 
happened in detail.

The reason were easy to find: a file name written by Windows via samba had 
an invalid encoding. This thing is now happened again and this time I looked 
deeper (stack trace at end of mail). In gnome_cmd_file_setup at 
src/gnome-cmd-file.cc:190 g_utf8_collate_key_for_filename is called with 
that file name which has not UTF-8 encoding.
Because nautilus can handle those filenames, I took a look how it does. 
Short version: it doesn't use GnomeVFS anymore but GIO and referring to 
http://library.gnome.org/devel/references I see that GnomeVFS is deprecated.

How this behaviour should be handled now? "Porting" Gnome-Commander to GIO I 
can't do in finite time, because I would always work against you (assumption 
^^). Putting an libiconv call around is more a hack, by may work ...

What do you think?

/Jens

--- BEGIN STACK STRACE ---
(gnome-commander:21221): GLib-CRITICAL **: g_convert: assertion `str != 
NULL' failed

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x602180 (LWP 100418)]
0x000000080583bed3 in g_utf8_collate_key () from /usr/local/lib/libglib-2.0.so.0
(gdb) bt
#0  0x000000080583bed3 in g_utf8_collate_key () from 
/usr/local/lib/libglib-2.0.so.0
#1  0x000000080583c220 in g_utf8_collate_key_for_filename () from 
/usr/local/lib/libglib-2.0.so.0
#2  0x0000000000455857 in gnome_cmd_file_setup (finfo=0xa25d00, 
info=0x916920, dir=0xa035b0) at gnome-cmd-file.cc:190
#3  0x000000000044043c in gnome_cmd_dir_new_from_info (info=0x916920, 
parent=0xa035b0) at gnome-cmd-dir.cc:282
#4  0x000000000044087e in on_list_done (dir=0xa035b0, infolist=0xb6ad60, 
result=Variable "result" is not available.
) at gnome-cmd-dir.cc:474
#5  0x0000000000419442 in dirlist_list (dir=0xa035b0, visprog=0) at 
dirlist.cc:127
#6  0x000000000043fbd3 in gnome_cmd_dir_relist_files (dir=0xa035b0, 
visprog=0) at gnome-cmd-dir.cc:583
#7  0x000000000043fc9b in gnome_cmd_dir_list_files (dir=0xa035b0, visprog=0) 
at gnome-cmd-dir.cc:597
#8  0x0000000000450c4c in gnome_cmd_file_selector_set_directory (fs=Variable 
"fs" is not available.
) at gnome-cmd-file-selector.cc:1588
#9  0x00000000004512de in do_file_specific_action (fs=0x779a40, 
finfo=0xa035b0) at gnome-cmd-file-selector.cc:772
#10 0x00000000004540a2 in gnome_cmd_file_selector_keypressed (fs=0x779a40, 
event=0xb25f30) at gnome-cmd-file-selector.cc:2086
#11 0x000000000045417c in on_list_key_pressed (clist=0x83f000, 
event=0xb25f30, fs=0x779a40) at gnome-cmd-file-selector.cc:1156
#12 0x000000080219ea11 in gtk_marshal_BOOLEAN__VOID () from 
/usr/local/lib/libgtk-x11-2.0.so.0
#13 0x00000008056aa37a in g_closure_invoke () from 
/usr/local/lib/libgobject-2.0.so.0
#14 0x00000008056bcbe4 in g_signal_handler_disconnect () from 
/usr/local/lib/libgobject-2.0.so.0
#15 0x00000008056be84f in g_signal_emit_valist () from 
/usr/local/lib/libgobject-2.0.so.0
#16 0x00000008056bef6a in g_signal_emit () from 
/usr/local/lib/libgobject-2.0.so.0
#17 0x000000080228fc88 in gtk_widget_get_default_style () from 
/usr/local/lib/libgtk-x11-2.0.so.0
#18 0x000000080229df2c in gtk_window_propagate_key_event () from 
/usr/local/lib/libgtk-x11-2.0.so.0
#19 0x00000008022a0780 in gtk_window_activate_key () from 
/usr/local/lib/libgtk-x11-2.0.so.0
#20 0x000000080219ea11 in gtk_marshal_BOOLEAN__VOID () from 
/usr/local/lib/libgtk-x11-2.0.so.0
#21 0x00000008056aa37a in g_closure_invoke () from 
/usr/local/lib/libgobject-2.0.so.0
#22 0x00000008056bd131 in g_signal_handler_disconnect () from 
/usr/local/lib/libgobject-2.0.so.0
#23 0x00000008056be84f in g_signal_emit_valist () from 
/usr/local/lib/libgobject-2.0.so.0
#24 0x00000008056bef6a in g_signal_emit () from 
/usr/local/lib/libgobject-2.0.so.0
#25 0x000000080228fc88 in gtk_widget_get_default_style () from 
/usr/local/lib/libgtk-x11-2.0.so.0
#26 0x00000008021997a6 in gtk_propagate_event () from 
/usr/local/lib/libgtk-x11-2.0.so.0
#27 0x000000080219a40a in gtk_main_do_event () from 
/usr/local/lib/libgtk-x11-2.0.so.0
#28 0x0000000802525821 in gdk_add_client_message_filter () from 
/usr/local/lib/libgdk-x11-2.0.so.0
#29 0x00000008058117ce in g_main_context_dispatch () from 
/usr/local/lib/libglib-2.0.so.0
#30 0x000000080581494b in g_main_context_check () from 
/usr/local/lib/libglib-2.0.so.0
#31 0x0000000805814d05 in g_main_loop_run () from 
/usr/local/lib/libglib-2.0.so.0
#32 0x000000080219a779 in gtk_main () from /usr/local/lib/libgtk-x11-2.0.so.0
#33 0x000000000047cb5a in main (argc=1, argv=Variable "argv" is not available.
) at main.cc:145
--- END STACK TRACE ---