Re: [gcmd-dev] fix for bug #377490

[Koos Jan Niesink]

Hello Piotr, 

Here it is ;) 
the new patch to fix the mkdir-dialog issues. I think this one fixes all issues 
you mentioned. 
1. It adds support for directories that start with a tilde.
2. network support
3. mkdir -p works
To make it work I had to add two functions to gnome-cmd-dir.c. These functions 
return an uri when given a filename or a path as input.

Please test this patch and report any errors.
I was wondering about one thing though. Should I replace functions like strchr 
with unicode enabled ones like g_utf8_strchr? 

koos

Piotr Eljasiak <address@hidden> wrote:1. Your solution is valid only for local 
connections. IMHO uri should be
constructed also from current (active) connection.

2. There are (rare) cases when gnome_vf_get_uri_from... may be NULL - we
need here reasonable escape path here

3. I've added 'if' for foo/bar case (simple check for presence of
G_DIR_SEPARATOR ;o) IMHO it should do to construct valid uri for nested
dirs once and pass it to gnome_vfs_make_directory_for_uri()

4. I've replaced g_strcasecmp with simple strcmp - the first one is
case-insensitive

May I ask you fill out mising parts?


TIA,
Piotr


                
---------------------------------
Win a BlackBerry device from O2 with Yahoo!. Enter now.

377490.tar.gz
Description: 555659916-377490.tar.gz