Re: [gcmd-dev] fix for bug #377490

[Koos Jan Niesink]

Hello, 

To make things clearer I decided to make a table with all the possibilities of 
the commands which can be issued through the mkdir-dialog (F7).

pwd                          command                              result

/home/koos/testdir    test_01                                    ok
/home/koos/testdir    /home/koos/testdir/test_02      fixed
/home/koos/testdir    ../test_03                                          
fixed, previously there was a 'zombie' dir
/home/koos/testdir    /home/koos/test_04                   fixed

/home/koos/testdir   test_05/test_06                                        not 
working yet
/home/koos/testdir    /home/koos/testdir/test_07/test_08  not working yet

create a dir test_09 in /home/koos/testdir

/home/koos/testdir    test_09/test_10                                        ok
/home/koos/testdir    /home/koos/testdir/test_09/test_11   fixed

I hope this gives a good overview what is working and what is not working 
concerning the creation of directories in gnome-commander.

Hope this helps,
koos

ps. I think these issues are also valid for symlinking, but I haven't looked at 
that.

Micha <address@hidden> wrote: 
Great you can work on these issues, Koos :)

> While doing this I encountered a few problems:
> 1. Previously, in some cases when a directory was created it was displayed in 
> the wrong directory (see bug description). This happens with the following 
> command 'F7: ../testdir', this displays two times 'testdir' one in the 
> current directory (after ctr+r this one dissappears) and the really created 
> one in the parent directory.

Confirmed (1.3.4)

> My solution to this problem was to check whether the created directory is in 
> the working directory (or active pane).

But ../foo is _not_ in the pwd...?
This is btw. not only a display problem, gcmd actually tries to cd when i click 
the zombie dir
(which leads to some confusion, like moving the focus to the other pane). I 
think this could be 
related to the following below:

> 2. Creating nested directories like 'F7: dir1/dir2' doesn't work yet. 

Confirmed. This would be a useful feature. (Krusader can do this)
The error message 'file not found' is weird.

F7 ../foo and F7 foo/bar have in common that they consist of multiple-level 
path,
so maybe the parsing of URI to the function is buggy ?
Assumed the function is actually checking for sane input. Or maybe it doesn't.
I'm no coder, i'm only beta tester and semi-professional loudmouth. But i think,
anyway, there *should* be a feature like mkdir -p in gnomevfs....maybe another 
function ?

> To make this work I think path string must be split into multiple pathnames 
> and call the function gnome_vfs_make_directory_for_uri for each directory.

A valid solution. I hope piotr can pick it up.
And see my next posting :)


thx anyway! 



 m°


                
---------------------------------
To help you stay safe and secure online, we've developed the all new Yahoo! 
Security Centre.