[Freetype] Type1 fonts and face->underline_position bug

[Christophe Saout]

Hello,

I think there is a bug in Freetype2 (2.1.5 and 2.1.7 tested).
face->underline_position and face->underline_thickness give strange
values for Type 1 fonts (.pfb) but correct ones for TrueType fonts.

Removing the >> 16 in src/type1/t1objs.c produces correct results in my
case. What's wrong? There are other >> 16 for other font types too, I
haven't checked those.

diff -Nur freetype-2.1.5.orig/src/type1/t1objs.c
freetype-2.1.5/src/type1/t1objs.c
--- freetype-2.1.5.orig/src/type1/t1objs.c   2003-07-26 00:09:53 +0200
+++ freetype-2.1.5/src/type1/t1objs.c        2004-03-29 22:41:51 +0200
@@ -434,8 +434,8 @@
                                                                                
                                          
       root->max_advance_height = root->height;
                                                                                
                                          
-      root->underline_position  = info->underline_position >> 16;
-      root->underline_thickness = info->underline_thickness >> 16;
+      root->underline_position  = info->underline_position;
+      root->underline_thickness = info->underline_thickness;
                                                                                
                                          
       root->internal->max_points   = 0;
       root->internal->max_contours = 0;